[GitHub] [apisix-dashboard] liuxiran commented on pull request #1633: feat: add the service page upstream select option

Sun, 04 Apr 2021 11:10:06 -0700 


liuxiran commented on pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-813075562


   > Hi @liuxiran
   > 
   > Thanks for your detailed explanation, I update the commit please review it 
again.
   > 
   > 
![image](https://user-images.githubusercontent.com/22230889/112566531-22425b00-8e1a-11eb-8492-3f355952a064.png)
   
   sorry for late reply, UI has been fixed 👍,  and there is another error in my 
local env:
   when I try to create a service with `None` upstream, I will got an error
   
   
![image](https://user-images.githubusercontent.com/2561857/113517525-0de92580-95b3-11eb-8c0f-d3dc504a74f0.png)
   
   
![image](https://user-images.githubusercontent.com/2561857/113517548-26f1d680-95b3-11eb-933f-52ba190ae43d.png)
   
   actually when we choose `None` upstream, we do not have to pass 
`upstream_id` to the manager-api, you can try to solve this in `onSubmit` 
function in the 
https://github.com/apache/apisix-dashboard/blob/master/web/src/pages/Service/Create.tsx
    
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to