Yiyiyimu commented on a change in pull request #3926:
URL: https://github.com/apache/apisix/pull/3926#discussion_r607112512
##########
File path: Makefile
##########
@@ -240,11 +240,11 @@ test:
### license-check: Check Lua source code for Apache License
.PHONY: license-check
license-check:
-ifeq ("$(wildcard .travis/openwhisk-utilities/scancode/scanCode.py)", "")
- git clone https://github.com/apache/openwhisk-utilities.git
.travis/openwhisk-utilities
- cp .travis/ASF* .travis/openwhisk-utilities/scancode/
+ifeq ("$(wildcard ci/openwhisk-utilities/scancode/scanCode.py)", "")
+ git clone https://github.com/apache/openwhisk-utilities.git
ci/openwhisk-utilities
+ cp ci/ASF* ci/openwhisk-utilities/scancode/
Review comment:
wow that's the idea coming from the podcast of ACL Beijing discussing
summer 2021 and they really made it! Cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
