jbampton commented on pull request #3624: URL: https://github.com/apache/apisix/pull/3624#issuecomment-816190139
> The pre-commit framework is good. > But does it add any value as we already check them in the CI? There are many duplicate rules between this framework and the CI files. I don't want to increase the maintain burden and make amateur harder to do contribution. Hey @spacewander so seems maybe we are moving to use the GitHub Super-Linter on the CI since it provides more language checks or tests than the current GitHub Actions and is more robust and better supported. So we should have more docs with all basic tools listed and advise people on the different ways they can contribute and test. So we can have maybe three different levels of GitHub user or testing: - amateur: for no local testing, running all tests with the GitHub Super Linter and not installing the `pre-commit` framework - medium: some local testing with the `common` linting tools provided by both Shell and Batch files and running all tests with the GitHub Super Linter and not installing the `pre-commit` framework - advanced: installing and using the `pre-commit` framework for local tests and for added automation with additional backup tests using the GitHub Super Linter for validation > > It does say that `pre-commit` can be run on CI -> https://pre-commit.com/#usage-in-continuous-integration > > Cool! I think it would be better if we could do that in this PR So @Yiyiyimu is pushing for using the `pre-commit` framework on the CI and maybe this is used instead of the GitHub Super Linter or perhaps together with it for even more tests and coverage. Between the GitHub Super Linter, `pre-commit` and `Prettier` there seems to be a lot of things you do, check and test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
