[GitHub] [apisix] jbampton commented on a change in pull request #4014: fix(prometheus): collect nginx_status and return the body

[GitBox]

jbampton commented on a change in pull request #4014:
URL: https://github.com/apache/apisix/pull/4014#discussion_r610359798



##########
File path: t/cli/test_prometheus.sh
##########
@@ -35,6 +35,11 @@ if [ ! $code -eq 200 ]; then
     exit 1
 fi
 
+if ! curl -i http://127.0.0.1:9091/apisix/prometheus/metrics | grep 
"apisix_nginx_http_current_connections" > /dev/null; then
+    echo "failed: should listen default prometheus address"

Review comment:
       ```suggestion
       echo "failed: should listen at default prometheus address"
   ```

##########
File path: t/cli/test_prometheus.sh
##########
@@ -35,6 +35,11 @@ if [ ! $code -eq 200 ]; then
     exit 1
 fi
 
+if ! curl -i http://127.0.0.1:9091/apisix/prometheus/metrics | grep 
"apisix_nginx_http_current_connections" > /dev/null; then
+    echo "failed: should listen default prometheus address"
+    exit 1
+fi
+
 make stop
 
 echo "passed: should listen default prometheus address"

Review comment:
       ```suggestion
   echo "passed: should listen at default prometheus address"
   ```

##########
File path: t/cli/test_prometheus.sh
##########
@@ -35,6 +35,11 @@ if [ ! $code -eq 200 ]; then
     exit 1
 fi
 
+if ! curl -i http://127.0.0.1:9091/apisix/prometheus/metrics | grep 
"apisix_nginx_http_current_connections" > /dev/null; then
+    echo "failed: should listen default prometheus address"
+    exit 1
+fi
+
 make stop
 
 echo "passed: should listen default prometheus address"

Review comment:
       Some more in this file further down I think should be the same for 
better grammar like for:
   
   `should listen at ....`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org