tokers commented on a change in pull request #4019:
URL: https://github.com/apache/apisix/pull/4019#discussion_r611143601
##########
File path: docs/en/latest/plugins/traffic-split.md
##########
@@ -42,7 +42,7 @@ Note: The ratio between each upstream may not so accurate
since the drawback of
| Name | Type | Requirement | Default |
Valid | Description
|
| ------------------------------ | ------------- | ----------- | ------- |
------- |
----------------------------------------------------------------------------------------
|
-| rules.match | array[object] | optional | | |
List of matching rules.
|
+| rules.match | array[object] | optional | | |
List of matching rules. When `match` is configured, check whether `match` is
passed according to the configuration information, otherwise, `match` is passed
by default. |
Review comment:
The description is not so effective.
```suggestion
| rules.match | array[object] | optional | |
| List of matching rules, by default the list is empty and the rule will be
executed unconditionally. |
```
##########
File path: docs/zh/latest/plugins/traffic-split.md
##########
@@ -42,7 +42,7 @@ traffic-split 插件使用户可以逐步引导各个上游之间的流量百分
| 参数名 | 类型 | 可选项 | 默认值 | 有效值 | 描述
|
| ---------------------- | --------------| ------ | ------ | ------ |
-------------------- |
-| rules.match | array[object] | 可选 | | |
匹配规则列表 |
+| rules.match | array[object] | 可选 | | |
匹配规则列表。当配置了 `match` 时，根据配置信息进行校验 `match` 是否通过，否则，默认 `match` 通过。 |
Review comment:
```suggestion
| rules.match | array[object] | 可选 | | |
匹配规则列表，默认为空且规则将被无条件执行。|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
