Yiyiyimu commented on pull request #3624: URL: https://github.com/apache/apisix/pull/3624#issuecomment-817663588
Hi @jbampton Thank you for your contribution and actually I quite like how pre-commit works and what it improves! Some points that I found could be better: 1. replace the original Actions with pre-commit in CI in this PR. Since we don't need two tools to do the same thing, it's better to do the replacement rather than just addition. It's also the same about Super-Linter. 2. add a script and make it could be called from Makefile to install pre-commit locally, so users would not be confusing about how to install it. 3. There are quite a lot of checks for python files, AFAIK `debug-statements` / `https://github.com/psf/black` / `https://github.com/asottile/dead` which I don't think is necessary for this repo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
