membphis commented on a change in pull request #159:
URL: https://github.com/apache/apisix-docker/pull/159#discussion_r614131005
##########
File path: .github/workflows/apisix_push_docker_hub.yaml
##########
@@ -0,0 +1,24 @@
+name: Push apisix to Docker image
+on:
+ release:
+ types: [ published ]
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ platform:
+ - alpine
+ - centos
+
+ steps:
+ - name: Check out the repo
+ uses: actions/checkout@v2
+
+ - name: Login
+ run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login --username=${{
secrets.DOCKER_USERNAME }} --password-stdin
+
+ - name: Push apisix image to Docker Hub
+ run:
+ make build-on-${{ matrix.platform }}
+ make push-on-${{ matrix.platform }}
Review comment:
we'd better add a blank line at the end of file
##########
File path: .github/workflows/dashboard_push_docker_hub.yaml
##########
@@ -0,0 +1,19 @@
+name: Push apisix dashboard to Docker image
+on:
+ release:
+ types: [ published ]
+jobs:
+ build:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Check out the repo
+ uses: actions/checkout@v2
+
+ - name: Login
+ run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login --username=${{
secrets.DOCKER_USERNAME }} --password-stdin
+
+ - name: Push apisix dashboard image to Docker Hub
+ run:
+ make build-on-dashboard
+ make push-on-dashboard
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
