qian0817 commented on a change in pull request #1779:
URL: https://github.com/apache/apisix-dashboard/pull/1779#discussion_r615209916
##########
File path: web/src/components/RawDataEditor/RawDataEditor.tsx
##########
@@ -154,19 +154,19 @@ const RawDataEditor: React.FC<Props> = ({ visible,
readonly = true, type, data =
handleModeChange(value);
}}
data-cy='code-mirror-mode'
- ></Select>,
+ />,
Review comment:
> You can use the self-closing form of the `Select tag` since there are
no children in it
I don't get it, can you explain more or provide suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
