[GitHub] [apisix-dashboard] ericsyh opened a new pull request #1782: fix: upstream host form warning message

Fri, 16 Apr 2021 23:49:41 -0700 


ericsyh opened a new pull request #1782:
URL: https://github.com/apache/apisix-dashboard/pull/1782


   Signed-off-by: EricSyh <[email protected]>
   
   Please answer these questions before submitting a pull request, **or your PR 
will get closed**.
   
   **Why submit this pull request?**
   
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   The warning message of host form on upstream/services create pages uses raw 
regexp as below which is unfriendly to users. 
   
   <img width="1184" alt="截屏2021-04-17 下午2 40 56" 
src="https://user-images.githubusercontent.com/10498732/115104472-3b5aa980-9f8b-11eb-935b-ba3447f33b31.png";>
   
   So i modified nodes component under upstream to add an easy-to-understand 
warning message look like: 
   
   <img width="1186" alt="截屏2021-04-17 下午2 40 33" 
src="https://user-images.githubusercontent.com/10498732/115104574-fe42e700-9f8b-11eb-836b-3b97834ce19d.png";>
   
   
   **Related issues**
   
   No related issues. 
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, 
please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to