tokers commented on a change in pull request #4069:
URL: https://github.com/apache/apisix/pull/4069#discussion_r615330851
##########
File path: apisix/plugins/skywalking.lua
##########
@@ -126,6 +126,11 @@ function _M.init()
-- TODO: maybe need to fetch them from plugin-metadata
local metadata_shdict = ngx.shared.tracing_buffer
+
+ if local_plugin_info.service_instance_name == "__hostname__" then
Review comment:
The variable style that we use in APISIX always with the prefix `$`.
What about `$hostname`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
