[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1784: fix: show correct health checker

Sun, 18 Apr 2021 15:38:47 -0700 


liuxiran commented on a change in pull request #1784:
URL: https://github.com/apache/apisix-dashboard/pull/1784#discussion_r615463646



##########
File path: web/src/components/Upstream/locales/zh-CN.ts
##########
@@ -95,4 +94,10 @@ export default {
 
   'component.upstream.fields.checks.passive.unhealthy.timeouts': '超时时间',
   'component.upstream.fields.checks.passive.unhealthy.timeouts.tooltip': 
'根据被动健康检查的观察，在代理中认为目标不健康的超时次数。',
+
+  'component.upstream.other.none': '不选择（仅在绑定服务时可用）',

Review comment:
       we will reuse `UpstreamForm` when creating a service
   
   
![image](https://user-images.githubusercontent.com/2561857/115162774-f85a1c80-a0d7-11eb-8607-2fc3c34f4e9d.png)
   
   so remove `（仅在绑定服务时可用）` may be  more general here or change another remark 
^_^




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to