tokers commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617124870
##########
File path: pkg/ingress/apisix_route.go
##########
@@ -16,30 +16,44 @@ package ingress
import (
"context"
+ "fmt"
"time"
"go.uber.org/zap"
+ v1 "k8s.io/api/core/v1"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
+ "k8s.io/apimachinery/pkg/api/meta"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+ "k8s.io/client-go/kubernetes/scheme"
+ typedcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
"k8s.io/client-go/tools/cache"
+ "k8s.io/client-go/tools/record"
"k8s.io/client-go/util/workqueue"
"github.com/apache/apisix-ingress-controller/pkg/kube"
+
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/typed/config/v2alpha1"
"github.com/apache/apisix-ingress-controller/pkg/log"
"github.com/apache/apisix-ingress-controller/pkg/types"
apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
)
+const _routeController = "RouteController"
Review comment:
I am wondering whether we need a finer granularity component in
apisix-ingress-controller. The pod events reporters are "kubelet", "scheduler",
it's a whole program, not a module inside it.
##########
File path: pkg/ingress/endpoint.go
##########
@@ -181,8 +181,8 @@ func (c *endpointsController) onAdd(obj interface{}) {
if !c.controller.namespaceWatching(key) {
return
}
- log.Debugw("endpoints add event arrived",
- zap.Any("object", obj))
+ //log.Debugw("endpoints add event arrived",
Review comment:
Why comment it?
##########
File path: pkg/ingress/apisix_upstream.go
##########
@@ -122,6 +133,8 @@ func (c *apisixUpstreamController) sync(ctx
context.Context, ev *types.Event) er
svc, err := c.controller.svcLister.Services(namespace).Get(name)
if err != nil {
log.Errorf("failed to get service %s: %s", key, err)
+ message := fmt.Sprintf(_messageResourceFailed,
_upstreamController, err.Error())
Review comment:
Can these two lines be encapsulated into one function? they used in many
places, and once you need to change, you have to change everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
