tokers commented on a change in pull request #4105: URL: https://github.com/apache/apisix/pull/4105#discussion_r618261432
########## File path: docs/en/latest/health-check.md ########## @@ -26,8 +26,13 @@ title: Health Check Health Check of APISIX is based on [lua-resty-healthcheck](https://github.com/Kong/lua-resty-healthcheck), you can use it for upstream. -Note that we only start the health check when the upstream is hit by a request. +Note: + +* We only start the health check when the upstream is hit by a request. There won't be any health check if an upstream is configured but isn't in used. +* If there is not healthy node can be chosen, we will continue to access the upstream. Review comment: ```suggestion * If there is no healthy node can be chosen, we will continue to access the upstream. ``` ########## File path: docs/en/latest/health-check.md ########## @@ -26,8 +26,13 @@ title: Health Check Health Check of APISIX is based on [lua-resty-healthcheck](https://github.com/Kong/lua-resty-healthcheck), you can use it for upstream. -Note that we only start the health check when the upstream is hit by a request. +Note: + +* We only start the health check when the upstream is hit by a request. There won't be any health check if an upstream is configured but isn't in used. +* If there is not healthy node can be chosen, we will continue to access the upstream. +* We won't start the health check when the upstream only has one node, as we will access +it whether this unique node is healthy or not. Review comment: ```suggestion it no matter this unique node is healthy or not. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
