juzhiyuan commented on a change in pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#discussion_r618296183
##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-loop-func */
+/* eslint-disable @typescript-eslint/no-invalid-this */
Review comment:
Hi, do we need this?
##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -53,10 +55,11 @@ context('Create and Search Route', () => {
// eslint-disable-next-line no-loop-func
cy.get(this.domSelector.drawerBody).within(() => {
- cy.contains('Add').click();
- cy.get(this.domSelector.labels_0_labelKey).type(`label${i}`);
+ cy.contains('Add').click().then(() => {
+ cy.get(this.domSelector.labels_0_labelKey).type(`label${i}`);
cy.get(this.domSelector.labels_0_labelValue).type(`value${i}`);
Review comment:
It seems that there have some spaces?
##########
File path: web/src/components/Plugin/data.tsx
##########
@@ -25,6 +25,25 @@ export const PLUGIN_ICON_LIST: Record<string, any> = {
'authz-keycloak': <IconFont name="iconkeycloak_icon_32px" />,
'openid-connect': <IconFont name="iconicons8-openid" />,
'kafka-logger': <IconFont name="iconApache_kafka" />,
+ 'basic-auth': <IconFont name="iconbasic-auth" />,
Review comment:
Good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
