[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Thu, 22 Apr 2021 16:46:05 -0700 


iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-825271238


   > > All icons added now!
   > 
   > > 
   > 
   > > 
![scrnli_22_04_2021_19-58-03](https://user-images.githubusercontent.com/40708551/115731858-1ad48a00-a3a5-11eb-9c39-fc7b705c44ea.png)
   > 
   > 
   > 
   > Looks good. Just my previous concern of icons relative sizes (Maybe handle 
in a different PR or in this, as you wish) and the thing with "jwt-auth" icon 
if it could be redesigned.
   > 
   > Rest, LGTM. 
   
   Will be adding your suggestion in next PR
   THANK YOU


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to