nic-chen commented on a change in pull request #1830:
URL: https://github.com/apache/apisix-dashboard/pull/1830#discussion_r622000033
##########
File path: api/internal/handler/route_online_debug/route_online_debug.go
##########
@@ -70,6 +71,11 @@ type Result struct {
}
func (h *Handler) DebugRequestForwarding(c droplet.Context) (interface{},
error) {
+ if !conf.OnlineDebugConfig.Enable {
+ return &data.SpecCodeResponse{StatusCode:
http.StatusBadRequest},
+ fmt.Errorf("should enable the online debug in
managerapi")
Review comment:
```suggestion
fmt.Errorf("should enable the online debug in
conf.yaml")
```
##########
File path: api/test/docker/manager-api-conf.yaml
##########
@@ -25,6 +25,8 @@
- 172.16.238.10:2379 # ips here are defined in docker compose.
- 172.16.238.11:2379
- 172.16.238.12:2379
+ online_debug:
+ enable: true
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
