tokers commented on a change in pull request #408:
URL:
https://github.com/apache/apisix-ingress-controller/pull/408#discussion_r622676190
##########
File path: pkg/ingress/status.go
##########
@@ -55,26 +55,32 @@ func recordStatus(at interface{}, reason string, err error,
status v1.ConditionS
v.Status.Conditions = &conditions
}
meta.SetStatusCondition(v.Status.Conditions, condition)
- _, _ =
kube.GetApisixClient().ApisixV1().ApisixTlses(v.Namespace).
- UpdateStatus(context.TODO(), v, metav1.UpdateOptions{})
+ if _, errRecord :=
kube.GetApisixClient().ApisixV1().ApisixTlses(v.Namespace).
+ UpdateStatus(context.TODO(), v,
metav1.UpdateOptions{}); errRecord != nil {
+ log.Errorf("resource record error: %s/%s, with err %s",
v.Namespace, v.Name, errRecord.Error())
Review comment:
Your error log lost some vital contexts like recording which resource?
What does the resource look like?
```suggestion
log.Errorw("failed to record status change for
ApisixTls",
zap.Error(err),
zap.String("name", v.Name),
zap.String("namespace", v.Namespace),
)
```
##########
File path: pkg/ingress/status.go
##########
@@ -55,26 +55,32 @@ func recordStatus(at interface{}, reason string, err error,
status v1.ConditionS
v.Status.Conditions = &conditions
}
meta.SetStatusCondition(v.Status.Conditions, condition)
- _, _ =
kube.GetApisixClient().ApisixV1().ApisixTlses(v.Namespace).
- UpdateStatus(context.TODO(), v, metav1.UpdateOptions{})
+ if _, errRecord :=
kube.GetApisixClient().ApisixV1().ApisixTlses(v.Namespace).
+ UpdateStatus(context.TODO(), v,
metav1.UpdateOptions{}); errRecord != nil {
+ log.Errorf("resource record error: %s/%s, with err %s",
v.Namespace, v.Name, errRecord.Error())
+ }
case *configv1.ApisixUpstream:
// set to status
if v.Status.Conditions == nil {
conditions := make([]metav1.Condition, 0)
v.Status.Conditions = &conditions
}
meta.SetStatusCondition(v.Status.Conditions, condition)
- _, _ =
kube.GetApisixClient().ApisixV1().ApisixUpstreams(v.Namespace).
- UpdateStatus(context.TODO(), v, metav1.UpdateOptions{})
+ if _, errRecord :=
kube.GetApisixClient().ApisixV1().ApisixUpstreams(v.Namespace).
+ UpdateStatus(context.TODO(), v,
metav1.UpdateOptions{}); errRecord != nil {
+ log.Errorf("resource record error: %s/%s, with err %s",
v.Namespace, v.Name, errRecord.Error())
+ }
case *configv2alpha1.ApisixRoute:
// set to status
if v.Status.Conditions == nil {
conditions := make([]metav1.Condition, 0)
v.Status.Conditions = &conditions
}
meta.SetStatusCondition(v.Status.Conditions, condition)
- _, _ =
kube.GetApisixClient().ApisixV2alpha1().ApisixRoutes(v.Namespace).
- UpdateStatus(context.TODO(), v, metav1.UpdateOptions{})
+ if _, errRecord :=
kube.GetApisixClient().ApisixV2alpha1().ApisixRoutes(v.Namespace).
+ UpdateStatus(context.TODO(), v,
metav1.UpdateOptions{}); errRecord != nil {
+ log.Errorf("resource record error: %s/%s, with err %s",
v.Namespace, v.Name, errRecord.Error())
Review comment:
Ditto.
##########
File path: pkg/ingress/status.go
##########
@@ -55,26 +55,32 @@ func recordStatus(at interface{}, reason string, err error,
status v1.ConditionS
v.Status.Conditions = &conditions
}
meta.SetStatusCondition(v.Status.Conditions, condition)
- _, _ =
kube.GetApisixClient().ApisixV1().ApisixTlses(v.Namespace).
- UpdateStatus(context.TODO(), v, metav1.UpdateOptions{})
+ if _, errRecord :=
kube.GetApisixClient().ApisixV1().ApisixTlses(v.Namespace).
+ UpdateStatus(context.TODO(), v,
metav1.UpdateOptions{}); errRecord != nil {
+ log.Errorf("resource record error: %s/%s, with err %s",
v.Namespace, v.Name, errRecord.Error())
+ }
case *configv1.ApisixUpstream:
// set to status
if v.Status.Conditions == nil {
conditions := make([]metav1.Condition, 0)
v.Status.Conditions = &conditions
}
meta.SetStatusCondition(v.Status.Conditions, condition)
- _, _ =
kube.GetApisixClient().ApisixV1().ApisixUpstreams(v.Namespace).
- UpdateStatus(context.TODO(), v, metav1.UpdateOptions{})
+ if _, errRecord :=
kube.GetApisixClient().ApisixV1().ApisixUpstreams(v.Namespace).
+ UpdateStatus(context.TODO(), v,
metav1.UpdateOptions{}); errRecord != nil {
+ log.Errorf("resource record error: %s/%s, with err %s",
v.Namespace, v.Name, errRecord.Error())
Review comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
