spacewander commented on a change in pull request #4175:
URL: https://github.com/apache/apisix/pull/4175#discussion_r625455517
##########
File path: docs/en/latest/config.json
##########
@@ -162,6 +162,13 @@
"discovery/eureka"
]
},
+ {
+ "type": "category",
+ "label": "Examples",
Review comment:
This section is not part of the category.
##########
File path: docs/en/latest/plugins/skywalking.md
##########
@@ -101,7 +101,7 @@ plugin_attr:
skywalking:
service_name: APISIX
service_instance_name: "APISIX Instance Name"
- endpoint_addr: http://127.0.0.1:12800
+ endpoint_addr: `http://127.0.0.1:12800`
Review comment:
Don't blindly add '``'.
##########
File path: docs/en/latest/plugins/authz-keycloak.md
##########
@@ -42,9 +42,9 @@ For more information on Keycloak, refer to [Keycloak
Authorization Docs](https:/
| Name | Type | Requirement | Default
| Valid
| Description
|
| ------------------------------ | ------------- | ----------- |
--------------------------------------------- |
------------------------------------------------------------------ |
-----------------------------------------------------------------------------------------------------------------------------------------------------------
|
-| discovery | string | optional |
|
https://host.domain/auth/realms/foo/.well-known/uma2-configuration | URL to
discovery document for Keycloak Authorization Services.
|
-| token_endpoint | string | optional |
|
https://host.domain/auth/realms/foo/protocol/openid-connect/token | A
OAuth2-compliant Token Endpoint that supports the
`urn:ietf:params:oauth:grant-type:uma-ticket` grant type. Overrides value from
discovery, if given. |
-| resource_registration_endpoint | string | optional |
|
https://host.domain/auth/realms/foo/authz/protection/resource_set | A Keycloak
Protection API-compliant resource registration endpoint. Overrides value from
discovery, if given. |
+| discovery | string | optional |
|
`https://host.domain/auth/realms/foo/.well-known/uma2-configuration` | URL to
discovery document for Keycloak Authorization Services.
|
Review comment:
Why add '``' surround the link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
