KishaniKandasamy commented on a change in pull request #4175:
URL: https://github.com/apache/apisix/pull/4175#discussion_r625550360
##########
File path: docs/en/latest/plugins/authz-keycloak.md
##########
@@ -42,9 +42,9 @@ For more information on Keycloak, refer to [Keycloak
Authorization Docs](https:/
| Name | Type | Requirement | Default
| Valid
| Description
|
| ------------------------------ | ------------- | ----------- |
--------------------------------------------- |
------------------------------------------------------------------ |
-----------------------------------------------------------------------------------------------------------------------------------------------------------
|
-| discovery | string | optional |
|
https://host.domain/auth/realms/foo/.well-known/uma2-configuration | URL to
discovery document for Keycloak Authorization Services.
|
-| token_endpoint | string | optional |
|
https://host.domain/auth/realms/foo/protocol/openid-connect/token | A
OAuth2-compliant Token Endpoint that supports the
`urn:ietf:params:oauth:grant-type:uma-ticket` grant type. Overrides value from
discovery, if given. |
-| resource_registration_endpoint | string | optional |
|
https://host.domain/auth/realms/foo/authz/protection/resource_set | A Keycloak
Protection API-compliant resource registration endpoint. Overrides value from
discovery, if given. |
+| discovery | string | optional |
|
`https://host.domain/auth/realms/foo/.well-known/uma2-configuration` | URL to
discovery document for Keycloak Authorization Services.
|
Review comment:
I thought ,If a phrase doesn't direct to any page ,we could better go
with `` rather than explicitly showing it as a link,,something like
It would be more helpful to me if you @spacewander explain me why you used
(``) `http://127.0.0.1:9080/apisix/dashboard/` in
https://apisix.apache.org/docs/apisix/plugins/limit-req#how-to-enable-on-the-route-or-serivce.
As I really don't know how to explain this, I would like to request @juzhiyuan
too to review this PR ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
