tokers commented on a change in pull request #4164:
URL: https://github.com/apache/apisix/pull/4164#discussion_r629797144
##########
File path: apisix/cli/ops.lua
##########
@@ -605,6 +614,7 @@ local function start(env, ...)
local cmd_logs = "mkdir -p " .. env.apisix_home .. "/logs"
util.execute_cmd(cmd_logs)
+
Review comment:
Why adding an empty line here?
##########
File path: apisix/init.lua
##########
@@ -534,6 +533,10 @@ end
function _M.http_header_filter_phase()
+ if not ngx.ctx or not ngx.ctx.api_ctx then
+ ngx.ctx = ctxdump.apply_ngx_ctx(ngx_var.ctx_ref)
Review comment:
Stash `ngx.ctx` unconditionally but checking the existence of `ngx.ctx`
, this behavior leaks some keys for `ngx.ctx` tables (for those requests which
doesn't make internal redirect).
##########
File path: t/error_page/error_page.t
##########
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
Review comment:
Ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
