Gary-Airwallex opened a new issue #4229:
URL: https://github.com/apache/apisix/issues/4229


   ### Proposed changes
   https://github.com/apache/apisix/pull/4152 supports redirect with regex, but 
1. it does not append the query string from original request to the Location 
header, and 2. it does not encode url. I suggest fxing these as in 
proxy-rewrite. If everyone agrees on this I'll create a PR for the change. 
   
   ### Concerns
   Proposed changes do change the behavior of current implementation, and it 
will cause problems if 
   1. someone expects the query string to be removed, or
   2. someone encodes url manually in plugin configuration, e.g. `"regex_uri": 
["/abc(.*)", "/ab%20c$1"],`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to