tao12345666333 commented on a change in pull request #74: URL: https://github.com/apache/apisix-helm-chart/pull/74#discussion_r631562371
########## File path: charts/apisix/Chart.lock ########## @@ -0,0 +1,12 @@ +dependencies: +- name: etcd + repository: https://charts.bitnami.com/bitnami + version: 5.2.1 +- name: apisix-dashboard + repository: https://charts.apiseven.com + version: 0.1.2 +- name: apisix-ingress-controller + repository: https://charts.apiseven.com + version: 0.4.0 +digest: sha256:111cf0f06c6039a02340f3ddafba83882336774ec5539dfceef8f6d59d5d6d34 +generated: "2021-05-11T15:52:54.405811637+08:00" Review comment: I think we should keep the Chart.lock file. This is a way to ensure that all users can get the same dependencies when using our Helm Chart. I refer to the helm repository of prometheus, which is currently widely used. https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/Chart.lock -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
