slene commented on a change in pull request #453:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/453#discussion_r633088880



##########
File path: pkg/ingress/apisix_cluster_config.go
##########
@@ -62,7 +64,6 @@ func (c *apisixClusterConfigController) run(ctx 
context.Context) {
                go c.runWorker(ctx)
        }
        <-ctx.Done()
-       c.workqueue.ShutDown()

Review comment:
       If not change them. Wiil cause goroutine leak in this pr. When re-create 
*controller.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to