This is an automated email from the ASF dual-hosted git repository. sunyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push: new 4627ca5 chore: refactored test create-route-with-api-breaker-from.spec.js (#1862) 4627ca5 is described below commit 4627ca5a7a90cd1ffb05520980ca9d32d67b8217 Author: Ayush das <ayush24...@gmail.com> AuthorDate: Mon May 17 07:43:19 2021 +0530 chore: refactored test create-route-with-api-breaker-from.spec.js (#1862) --- .../create-route-with-api-breaker-form.spec.js | 91 +++++++++++++--------- 1 file changed, 55 insertions(+), 36 deletions(-) diff --git a/web/cypress/integration/route/create-route-with-api-breaker-form.spec.js b/web/cypress/integration/route/create-route-with-api-breaker-form.spec.js index 93e3e2a..b09502b 100644 --- a/web/cypress/integration/route/create-route-with-api-breaker-form.spec.js +++ b/web/cypress/integration/route/create-route-with-api-breaker-form.spec.js @@ -18,69 +18,90 @@ context('Create and delete route with api-breaker form', () => { const selector = { + empty: '.ant-empty-normal', + name: '#name', + description: '#desc', + pluginCardBordered: '.ant-card-bordered', + disabledSwitcher: '#disable', + checkedSwitcher: '.ant-switch-checked', + drawer: '.ant-drawer-content', + nodes_0_host: '#nodes_0_host', + nodes_0_port: '#nodes_0_port', + nodes_0_weight: '#nodes_0_weight', break_response_code: '#break_response_code', - alert: '.ant-form-item-explain-error [role=alert]' - } + alert: '.ant-form-item-explain-error [role=alert]', + deleteAlert: '.ant-modal-body', + notificationCloseIcon: '.ant-notification-close-icon', + notification: '.ant-notification-notice-message', + }; + + const data = { + deleteRouteSuccess: 'Delete Route Successfully', + submitSuccess: 'Submit Successfully', + port: '80', + weight: 1, + }; beforeEach(() => { cy.login(); - - cy.fixture('selector.json').as('domSelector'); - cy.fixture('data.json').as('data'); }); it('should create route with api-breaker form', function () { cy.visit('/'); cy.contains('Route').click(); - cy.get(this.domSelector.empty).should('be.visible'); + cy.get(selector.empty).should('be.visible'); cy.contains('Create').click(); cy.contains('Next').click().click(); - cy.get(this.domSelector.name).type('routeName'); - cy.get(this.domSelector.description).type('desc'); + cy.get(selector.name).type('routeName'); + cy.get(selector.description).type('desc'); cy.contains('Next').click(); - cy.get(this.domSelector.nodes_0_host).type('127.0.0.1'); - cy.get(this.domSelector.nodes_0_port).clear().type(this.data.port); - cy.get(this.domSelector.nodes_0_weight).clear().type(this.data.weight); + cy.get(selector.nodes_0_host).type('127.0.0.1'); + cy.get(selector.nodes_0_port).clear().type(data.port); + cy.get(selector.nodes_0_weight).clear().type(data.weight); cy.contains('Next').click(); // config api-breaker plugin - cy.contains('api-breaker').parents(this.domSelector.pluginCardBordered).within(() => { - cy.get('button').click({ - force: true + cy.contains('api-breaker') + .parents(selector.pluginCardBordered) + .within(() => { + cy.get('button').click({ + force: true, + }); }); - }); - cy.get(this.domSelector.drawer).should('be.visible').within(() => { - cy.get(this.domSelector.disabledSwitcher).click(); - cy.get(this.domSelector.checkedSwitcher).should('exist'); - }); + cy.get(selector.drawer) + .should('be.visible') + .within(() => { + cy.get(selector.disabledSwitcher).click(); + cy.get(selector.checkedSwitcher).should('exist'); + }); // config api-breaker form without break_response_code cy.get(selector.break_response_code).click(); cy.get(selector.alert).contains('Please Enter break_response_code'); - cy.get(this.domSelector.drawer).within(() => { + cy.get(selector.drawer).within(() => { cy.contains('Submit').click({ force: true, }); }); - cy.get(this.domSelector.notification).should('contain', 'Invalid plugin data'); - cy.get(this.domSelector.notificationCloseIcon).click(); + cy.get(selector.notification).should('contain', 'Invalid plugin data'); + cy.get(selector.notificationCloseIcon).click(); // config api-breaker form with break_response_code cy.get(selector.break_response_code).type('200'); cy.get(selector.alert).should('not.exist'); - cy.get(this.domSelector.disabledSwitcher).click(); - cy.get(this.domSelector.drawer).within(() => { + cy.get(selector.disabledSwitcher).click(); + cy.get(selector.drawer).within(() => { cy.contains('Submit').click({ force: true, }); }); - cy.get(this.domSelector.drawer).should('not.exist'); + cy.get(selector.drawer).should('not.exist'); cy.contains('button', 'Next').click(); cy.contains('button', 'Submit').click(); - cy.contains(this.data.submitSuccess); + cy.contains(data.submitSuccess); // back to route list page cy.contains('Goto List').click(); @@ -89,19 +110,17 @@ context('Create and delete route with api-breaker form', () => { it('should delete the route', function () { cy.visit('/routes/list'); - const { - domSelector, - data - } = this; - cy.get(domSelector.name).clear().type('routeName'); + cy.get(selector.name).clear().type('routeName'); cy.contains('Search').click(); cy.contains('routeName').siblings().contains('More').click(); cy.contains('Delete').click(); - cy.get(domSelector.deleteAlert).should('be.visible').within(() => { - cy.contains('OK').click(); - }); - cy.get(domSelector.notification).should('contain', data.deleteRouteSuccess); - cy.get(domSelector.notificationCloseIcon).click(); + cy.get(selector.deleteAlert) + .should('be.visible') + .within(() => { + cy.contains('OK').click(); + }); + cy.get(selector.notification).should('contain', data.deleteRouteSuccess); + cy.get(selector.notificationCloseIcon).click(); }); });