gxthrj commented on a change in pull request #453:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/453#discussion_r634905420



##########
File path: pkg/ingress/controller.go
##########
@@ -423,3 +449,26 @@ func (c *Controller) syncSSL(ctx context.Context, ssl 
*apisixv1.Ssl, event types
        }
        return err
 }
+
+func (c *Controller) checkClusterHealthy(ctx context.Context) {
+       for {
+               select {
+               case <-ctx.Done():
+               case <-time.After(5 * time.Second):
+               }
+
+               // Retry three times in a row, and exit if all of them fail.
+               backoff := wait.Backoff{

Review comment:
       Why mark this as resolved?  in `case <-ctx.Done()` do not need the logic 
of health check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to