LiteSun commented on a change in pull request #1907:
URL: https://github.com/apache/apisix-dashboard/pull/1907#discussion_r638395660
##########
File path:
web/cypress/integration/consumer/create-consumer-with-api-breaker-plugin-form.spec.js
##########
@@ -60,17 +60,15 @@ context('Create and delete consumer with api-breaker plugin
form', () => {
});
cy.focused(selector.drawer).should('exist');
cy.get(selector.disabledSwitcher).click();
- // edit codemirror
- cy.get(selector.codeMirror)
- .first()
- .then((editor) => {
- editor[0].CodeMirror.setValue(
- JSON.stringify({
- key: 'test',
- }),
- );
- cy.contains('button', 'Submit').click();
- });
+ // wait loading
+ cy.wait(5000);
Review comment:
Do not use `cy.wait()` whenever possible.
##########
File path: web/package.json
##########
@@ -19,15 +19,15 @@
"lint:style": "stylelint --fix \"src/**/*.less\" --syntax less",
"prettier": "prettier -c --write \"**/*\"",
"site": "yarn run fetch:blocks && yarn run build",
- "start": "umi dev",
- "start:e2e": "cross-env SERVE_ENV=test umi dev",
+ "start": "cp -R ./node_modules/monaco-editor ./public/ && umi dev",
Review comment:
Why need to manually copy this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
