Firstsawyou commented on a change in pull request #4319:
URL: https://github.com/apache/apisix/pull/4319#discussion_r640731913
##########
File path: apisix/admin/init.lua
##########
@@ -286,9 +286,22 @@ local function post_reload_plugins()
end
-local function sync_local_conf_to_etcd()
- core.log.warn("sync local conf to etcd")
+local function plugins_eq(old, new)
Review comment:
Can we also compare `plugin_attr` for equality? Like this:
https://github.com/apache/apisix/blob/9a40fd7cb497974f9d7bd75f128eed5dd238cdc6/apisix/plugin.lua#L147-L153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
