spacewander commented on a change in pull request #4331:
URL: https://github.com/apache/apisix/pull/4331#discussion_r641330442
##########
File path: conf/config-default.yaml
##########
@@ -196,6 +196,8 @@ nginx_config: # config for render the
template to generate n
# After the maximum number of requests is
made, the connection is closed.
keepalive_timeout: 60s # Sets a timeout during which an idle
keepalive connection to an upstream server will stay open.
+ charset: utf-8 # Adds the specified charset to the
"Content-Type" response header field.
Review comment:
Personally, it would be more clear if we remove the blank line above.
And it would be better to link the `charset` directive in the comment.
##########
File path: t/cli/test_main.sh
##########
@@ -621,3 +621,21 @@ if ! grep "keepalive_timeout 6s;" conf/nginx.conf >
/dev/null; then
fi
echo "passed: found the keepalive related parameter in nginx.conf"
+
+# check the charset setting
+git checkout conf/config.yaml
+
+echo '
+nginx_config:
+ http:
+ charset: utf-8
Review comment:
Better to test with non-default value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
