liuxiran commented on a change in pull request #1907:
URL: https://github.com/apache/apisix-dashboard/pull/1907#discussion_r642331221
##########
File path: web/package.json
##########
@@ -19,15 +19,15 @@
"lint:style": "stylelint --fix \"src/**/*.less\" --syntax less",
"prettier": "prettier -c --write \"**/*\"",
"site": "yarn run fetch:blocks && yarn run build",
- "start": "umi dev",
- "start:e2e": "cross-env SERVE_ENV=test umi dev",
+ "start": "cp -R ./node_modules/monaco-editor ./public/ && umi dev",
Review comment:
I noticed that
> NOTE: For TypeScript type definitions, this package uses the monaco-editor
package as a peer dependency (reference:
https://github.com/suren-atoyan/monaco-react)
so yep, the `monaco-editor` dependence can not be reduced no matter what way
we use
hope a neater way to do this instead of cope `monaco` to the public dir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
