tao12345666333 commented on a change in pull request #89:
URL: https://github.com/apache/apisix-helm-chart/pull/89#discussion_r644466194
##########
File path: charts/apisix/templates/service-gateway.yaml
##########
@@ -28,6 +28,7 @@ metadata:
{{- include "apisix.labels" . | nindent 4 }}
spec:
type: {{ .Values.gateway.type }}
+ externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
Review comment:
Both `LoadBalancer` and `NodePort` are affected by this parameter.
I don’t think it is necessary to add judgment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
