tokers commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r644424720



##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -19,6 +19,8 @@ return [=[
 # Configuration File - Nginx Server Configs
 # This is a read-only file, do not try to modify it.
 
+user root;

Review comment:
       It's dangerous to use `root` to launch APISIX. Exposing this item to 
`config.yaml` so people can decide to use which user.

##########
File path: conf/config-default.yaml
##########
@@ -130,6 +130,9 @@ apisix:
   disable_sync_configuration_during_start: false  # safe exit. Remove this 
once the feature is stable
 
 nginx_config:                     # config for render the template to generate 
nginx.conf
+  #user: "root"                   # specifies the execution user of worker 
process.
+                                  # the "user" directive makes sense only if 
the master process runs with super-user privileges.
+                                  # if you is not root user,the default is 
current user.

Review comment:
       ```suggestion
                                     # if you're not root user,the default is 
current user.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to