tokers commented on a change in pull request #528:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/528#discussion_r647926547



##########
File path: samples/deploy/crd/v1beta1/ApisixRoute.yaml
##########
@@ -225,7 +225,6 @@ spec:
                             type: string
                     required:
                       - enable
-                      - type

Review comment:
       But seems like we don't have a default authentication way. When people 
enable auth but don't configure the specific authentication, actually no 
authentication is enabled, this behavior violated the semantic of field 
`enable`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to