spacewander commented on a change in pull request #4406:
URL: https://github.com/apache/apisix/pull/4406#discussion_r649002209
##########
File path: apisix/cli/ops.lua
##########
@@ -631,11 +631,10 @@ local function start(env, ...)
pid = tonumber(pid)
if pid then
local lsof_cmd = "lsof -p " .. pid
- local hd = popen(lsof_cmd)
- local res = hd:read("*a")
+ local res, err = util.execute_cmd(lsof_cmd)
Review comment:
We only can accept this change which refactors code and uses the common
way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
