qian0817 commented on a change in pull request #1907:
URL: https://github.com/apache/apisix-dashboard/pull/1907#discussion_r650465551
##########
File path:
web/cypress/integration/consumer/create-consumer-with-api-breaker-plugin-form.spec.js
##########
@@ -60,17 +59,13 @@ context('Create and delete consumer with api-breaker plugin
form', () => {
});
cy.focused(selector.drawer).should('exist');
cy.get(selector.disabledSwitcher).click();
- // edit codemirror
- cy.get(selector.codeMirror)
- .first()
- .then((editor) => {
- editor[0].CodeMirror.setValue(
- JSON.stringify({
- key: 'test',
- }),
- );
- cy.contains('button', 'Submit').click();
- });
+
+ // edit monaco
+ cy.window().then((window) => {
+ cy.waitUntil(() => window.monacoEditor)
Review comment:
@LiteSun Do you mean the onMount event?
##########
File path:
web/cypress/integration/consumer/create-consumer-with-api-breaker-plugin-form.spec.js
##########
@@ -60,17 +59,13 @@ context('Create and delete consumer with api-breaker plugin
form', () => {
});
cy.focused(selector.drawer).should('exist');
cy.get(selector.disabledSwitcher).click();
- // edit codemirror
- cy.get(selector.codeMirror)
- .first()
- .then((editor) => {
- editor[0].CodeMirror.setValue(
- JSON.stringify({
- key: 'test',
- }),
- );
- cy.contains('button', 'Submit').click();
- });
+
+ // edit monaco
+ cy.window().then((window) => {
+ cy.waitUntil(() => window.monacoEditor)
Review comment:
@guoqqqi It did't run well and some of the test cases run failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
