spacewander commented on a change in pull request #35: URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655192511
########## File path: CHANGELOG.md ########## @@ -0,0 +1,47 @@ +--- +title: Changelog +--- + +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> + +## Table of Contents + +- [0.1.0](#010) + +## 0.1.0 + +This release mainly improve basic features, bugfix and adds test cases. + +### Core + +- complete project skeleton and available features. +- complete joint debug with [APISIX](https://github.com/apache/apisix). +- mecessary documentation. [#19](https://github.com/apache/apisix-java-plugin-runner/pull/19) +- the test cases cover the codec. [#14](https://github.com/apache/apisix-java-plugin-runner/pull/14) +- the test cases cover the filter. [#15](https://github.com/apache/apisix-java-plugin-runner/pull/15) +- supported debug mode. Review comment: Where is the debug mode? I could not find it in the doc. ########## File path: CHANGELOG.md ########## @@ -0,0 +1,47 @@ +--- +title: Changelog +--- + +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> + +## Table of Contents + +- [0.1.0](#010) + +## 0.1.0 + +This release mainly improve basic features, bugfix and adds test cases. + +### Core + +- complete project skeleton and available features. +- complete joint debug with [APISIX](https://github.com/apache/apisix). Review comment: What does "complete joint debug" mean? ########## File path: CHANGELOG.md ########## @@ -0,0 +1,47 @@ +--- +title: Changelog +--- + +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> + +## Table of Contents + +- [0.1.0](#010) + +## 0.1.0 + +This release mainly improve basic features, bugfix and adds test cases. + +### Core + +- complete project skeleton and available features. +- complete joint debug with [APISIX](https://github.com/apache/apisix). +- mecessary documentation. [#19](https://github.com/apache/apisix-java-plugin-runner/pull/19) Review comment: Normally, we don't include doc/test in the Core section. ########## File path: CHANGELOG.md ########## @@ -0,0 +1,47 @@ +--- +title: Changelog +--- + +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> + +## Table of Contents + +- [0.1.0](#010) + +## 0.1.0 + +This release mainly improve basic features, bugfix and adds test cases. Review comment: This release mainly provides basic features and adds test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
