tokers commented on a change in pull request #558:
URL:
https://github.com/apache/apisix-ingress-controller/pull/558#discussion_r656933544
##########
File path: install.md
##########
@@ -40,6 +40,10 @@ kubectl kustomize
"github.com/apache/apisix-ingress-controller/samples/deploy?re
Parameters are hardcoded so if the default values are not good for you, just
tweak them manually.
+To tweak parameters, first you need to able to modify config files in
_samples/deploy_ directory. There are many ways to acheive this. For example,
you may insert a `sed` command after `kubectl kustomize`, that is, `kubectl
kustomize
"github.com/apache/apisix-ingress-controller/samples/deploy?ref=master" | sed
"s@to-be-modified@after-modified@g" | kubectl apply -f -`. Another way is to
use a local copy of _samples/deploy_ directory or a copy from your repo.
+
+Then you need to know which parameter need to be tweaked. If the value of
APISIX access token admin-key or apisix-baseUrl is changed, you need to modify
`apisix.admin_key` or `apisix.base_url` in field `.data.config.yaml` in file
_samples/deploy/configmap/apisix-ingress-cm.yaml_. Another example is to
install apisix-ingress-controller with different version, in which case you
need to configure `.spec.template.spec.containers.[image]` to a desired version
in file _samples/deploy/deployment/ingress-controller.yaml_.
Review comment:
apisix-baseUrl => the address of apisix admin api.
##########
File path: install.md
##########
@@ -40,6 +40,10 @@ kubectl kustomize
"github.com/apache/apisix-ingress-controller/samples/deploy?re
Parameters are hardcoded so if the default values are not good for you, just
tweak them manually.
+To tweak parameters, first you need to able to modify config files in
_samples/deploy_ directory. There are many ways to acheive this. For example,
you may insert a `sed` command after `kubectl kustomize`, that is, `kubectl
kustomize
"github.com/apache/apisix-ingress-controller/samples/deploy?ref=master" | sed
"s@to-be-modified@after-modified@g" | kubectl apply -f -`. Another way is to
use a local copy of _samples/deploy_ directory or a copy from your repo.
Review comment:
Remove the word "able ".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
