dmsolr commented on a change in pull request #44:
URL:
https://github.com/apache/apisix-java-plugin-runner/pull/44#discussion_r658581960
##########
File path: runner-dist/apisix-runner-src-dist/pom.xml
##########
@@ -63,8 +63,8 @@
</goals>
<configuration>
<target>
- <copy
file="${project.build.directory}/apisix-runner-src.tgz"
-
tofile="${project.basedir}/../../dist/apache-apisix-java-plugin-runner-${project.version}-src.tgz"
+ <copy
file="${project.build.directory}/apisix-java-plugin-runner.tgz"
+
tofile="${project.basedir}/../../apisix-java-plugin-runner-0.1.0.tgz"
Review comment:
I recommend replacing the version number with `${project.version}`.
And the version could exclude suffix `-RELEASE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
