tokers commented on a change in pull request #4490:
URL: https://github.com/apache/apisix/pull/4490#discussion_r659275611
##########
File path: apisix/plugins/key-auth.lua
##########
@@ -84,6 +88,12 @@ end
function _M.rewrite(conf, ctx)
local key = core.request.header(ctx, conf.header)
+
+ if not key then
Review comment:
We should not introduce using order implicitly.
##########
File path: apisix/plugins/key-auth.lua
##########
@@ -32,6 +32,10 @@ local schema = {
type = "string",
default = "apikey",
},
+ query = {
Review comment:
Should add some constraints to indicate that `query` and `header` are
exclusive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
