tao12345666333 commented on a change in pull request #571:
URL:
https://github.com/apache/apisix-ingress-controller/pull/571#discussion_r663875308
##########
File path: .github/workflows/e2e-test-ci.yml
##########
@@ -84,6 +84,10 @@ jobs:
run: |
go get -u github.com/onsi/ginkgo/ginkgo
sudo cp ~/go/bin/ginkgo /usr/local/bin
+ - name: Create K8s cluster
+ run: |
+ make kind-up
+ kubectl get nodes
Review comment:
should we need add `kubectl wait --for=condition=Ready nodes --all` to
wait node ready ?
##########
File path: .github/workflows/e2e-test-ci.yml
##########
@@ -73,7 +73,7 @@ jobs:
submodules: recursive
- name: Install kind
run: |
- curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.10.0/kind-linux-amd64
+ curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.11.0/kind-linux-amd64
Review comment:
should we update to v0.11.1 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
