spacewander commented on a change in pull request #4524:
URL: https://github.com/apache/apisix/pull/4524#discussion_r665796523
##########
File path: conf/config-default.yaml
##########
@@ -96,6 +96,9 @@ apisix:
# see
https://github.com/api7/lua-resty-radixtree/#parameters-in-path for
# more details.
ssl: 'radixtree_sni' # radixtree_sni: match route by SNI(base on
radixtree)
+ stream:
+ lua_shared_dict:
+ lrucache-lock-stream: 10m
Review comment:
We can omit the stream suffix?
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -57,7 +57,7 @@ env {*name*};
{% end %}
{% end %}
-{% if stream_proxy then %}
+{% if stream then %}
Review comment:
Why make this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]