arthur-zhang commented on a change in pull request #4558:
URL: https://github.com/apache/apisix/pull/4558#discussion_r665818101
##########
File path: apisix/api_router.lua
##########
@@ -90,14 +90,18 @@ function fetch_api_router()
core.json.delay_encode(api_routes, true))
for _, route in ipairs(api_routes) do
local typ_uri = type(route.uri)
- if typ_uri == "string" then
- has_route_not_under_apisix =
- not core.string.has_prefix(route.uri, "/apisix/")
- else
- for _, uri in ipairs(route.uri) do
+ if not has_route_not_under_apisix then
Review comment:
Maybe not，there is a lot of code under has_route_not_under_apisix value
finder.
If we break after outer for loop，the code left will be skipped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
