gxthrj commented on a change in pull request #563:
URL:
https://github.com/apache/apisix-ingress-controller/pull/563#discussion_r666172714
##########
File path: pkg/config/config.go
##########
@@ -67,13 +67,14 @@ type Config struct {
// KubernetesConfig contains all Kubernetes related config items.
type KubernetesConfig struct {
- Kubeconfig string `json:"kubeconfig"
yaml:"kubeconfig"`
- ResyncInterval types.TimeDuration `json:"resync_interval"
yaml:"resync_interval"`
- AppNamespaces []string `json:"app_namespaces"
yaml:"app_namespaces"`
- ElectionID string `json:"election_id"
yaml:"election_id"`
- IngressClass string `json:"ingress_class"
yaml:"ingress_class"`
- IngressVersion string `json:"ingress_version"
yaml:"ingress_version"`
- ApisixRouteVersion string `json:"apisix_route_version"
yaml:"apisix_route_version"`
+ Kubeconfig string `json:"kubeconfig"
yaml:"kubeconfig"`
+ ResyncInterval types.TimeDuration `json:"resync_interval"
yaml:"resync_interval"`
+ AppNamespaces []string `json:"app_namespaces"
yaml:"app_namespaces"`
+ ElectionID string `json:"election_id"
yaml:"election_id"`
+ IngressClass string `json:"ingress_class"
yaml:"ingress_class"`
+ IngressVersion string `json:"ingress_version"
yaml:"ingress_version"`
+ WatchEndpointSlices bool `json:"watch_endpoint_slices"
yaml:"watch_endpoint_slices"`
Review comment:
Should add the configuration for (k8s.io/api/discovery/v1)LabelManagedBy
? or reuse the field `IngressClass`?
##########
File path: go.mod
##########
@@ -19,8 +21,8 @@ require (
go.uber.org/zap v1.13.0
golang.org/x/net v0.0.0-20210224082022-3d97a244fca7
gopkg.in/yaml.v2 v2.4.0
- k8s.io/api v0.20.2
- k8s.io/apimachinery v0.20.2
- k8s.io/client-go v0.20.2
+ k8s.io/api v0.21.1
+ k8s.io/apimachinery v0.21.1
+ k8s.io/client-go v0.21.1
Review comment:
Once we upgrade the version of `client-go`, Please make sure what is
the minimum k8s version we can support, and modify the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
