gxthrj commented on a change in pull request #574:
URL:
https://github.com/apache/apisix-ingress-controller/pull/574#discussion_r666862729
##########
File path: pkg/ingress/controller.go
##########
@@ -504,6 +516,85 @@ func (c *Controller) syncConsumer(ctx context.Context,
consumer *apisixv1.Consum
}
return
}
+
+func (c *Controller) syncEndpoint(ctx context.Context, ep kube.Endpoint) error
{
Review comment:
Why write sync in the controller?
##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -256,6 +264,7 @@ spec:
- %s
- --apisix-route-version
- %s
+ - --watch-endpointslices
Review comment:
The default value of `watch-endpointslices` is false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
