gxthrj commented on a change in pull request #596:
URL:
https://github.com/apache/apisix-ingress-controller/pull/596#discussion_r670432614
##########
File path: pkg/ingress/manifest.go
##########
@@ -112,31 +144,38 @@ type manifest struct {
routes []*apisixv1.Route
upstreams []*apisixv1.Upstream
streamRoutes []*apisixv1.StreamRoute
+ ssl []*apisixv1.Ssl
}
func (m *manifest) diff(om *manifest) (added, updated, deleted *manifest) {
+ // TODO add diff ssl
Review comment:
Please remove the `TODO`.
##########
File path: pkg/kube/translation/ingress.go
##########
@@ -93,7 +96,37 @@ func (t *translator) translateIngressV1beta1(ing
*networkingv1beta1.Ingress) (*T
upstreamMap: make(map[string]struct{}),
}
plugins := t.translateAnnotations(ing.Annotations)
-
+ // TODO add https
Review comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
