Yiyiyimu commented on a change in pull request #4605: URL: https://github.com/apache/apisix/pull/4605#discussion_r673549520
########## File path: docs/en/latest/admin-api.md ########## @@ -568,6 +568,7 @@ In addition to the basic complex equalization algorithm selection, APISIX's Upst * `chash`: consistent hash * `ewma`: pick one of node which has minimum latency. See https://en.wikipedia.org/wiki/EWMA_chart for details. * `least_conn`: pick node which has the lowest `(active_conn + 1) / weight`. Note the `active connection` concept is the same with Nginx: it is a connection in used by a request. +* user-defined balancer which can be loaed via `require("apisix.balancer.your_balancer")`. Review comment: I failed to find the context so I'm not sure the relationship between "allow user-defined balancer" and "discovery when metadata changed". Are they two separate features? ########## File path: apisix/schema_def.lua ########## @@ -389,7 +389,6 @@ local upstream_schema = { type = { description = "algorithms of load balancing", type = "string", - enum = {"chash", "roundrobin", "ewma", "least_conn"} Review comment: do we need to test the behaviour when a non-user-defined algorithm is chosen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
