fgksgf commented on a change in pull request #601:
URL:
https://github.com/apache/apisix-ingress-controller/pull/601#discussion_r673587421
##########
File path: pkg/apisix/cache/cache.go
##########
@@ -35,6 +35,8 @@ type Cache interface {
InsertGlobalRule(*v1.GlobalRule) error
// InsertConsumer adds or updates consumer to cache.
InsertConsumer(*v1.Consumer) error
+ // InsertSchema adds or updates schema to cache.
+ InsertSchema(*v1.Schema) error
Review comment:
`v1.Schema` is the schema of APISIX objects, including plugin, route,
upstream, etc. So `InsertSchema` can be reused.
##########
File path: pkg/apisix/apisix.go
##########
@@ -54,6 +54,8 @@ type Cluster interface {
Consumer() Consumer
// HealthCheck checks apisix cluster health in realtime.
HealthCheck(context.Context) error
+ // Plugin returns a Plugin interface that can operate Plugin resources.
+ Plugin() Plugin
Review comment:
I will add a `Schema` client for getting schema of APISIX objects
(including plugin, route, upstream, etc.) and the `Plugin` will be only used to
query names of plugins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
