burntcarrot commented on pull request #1985:
URL: https://github.com/apache/apisix-dashboard/pull/1985#issuecomment-886194054


   > @burntcarrot Hi, I will request more reviewers. BTW, would you please 
check the Backend E2E tests? I'm not sure why it failed.
   
   @juzhiyuan I can confirm that these tests aren't failing due to the changes 
made in this PR. These are getting failed in other PRs too as mentioned by 
@RedemptionC.
   
   Those tests are failing due to some misconfiguration for some endpoints, I 
can see some requests returning `404` and `400` status codes in the traceback, 
here's an example:
   
   ```
   • Failure [0.053 seconds]
   Upstream update use patch method [It] create upstream via POST 
   
/home/runner/work/apisix-dashboard/apisix-dashboard/api/test/e2enew/upstream/upstream_test.go:721
   
     
        Error Trace:    reporter.go:23
                                                chain.go:21
                                                response.go:585
                                                response.go:151
                                                base.go:191
                                                upstream_test.go:734
                                                runner.go:113
                                                runner.go:64
                                                it_node.go:26
                                                spec.go:215
                                                spec.go:138
                                                spec_runner.go:200
                                                spec_runner.go:170
                                                spec_runner.go:66
                                                suite.go:79
                                                ginkgo_dsl.go:229
                                                ginkgo_dsl.go:210
                                                upstream_suite_test.go:31
        Error:          
                        expected status equal to:
                         "200 OK"
                        
                        but got:
                         "400 Bad Request"
        Test:           Upstream update use patch method create upstream via 
POST
     
   
     /home/runner/go/pkg/mod/github.com/gavv/httpexpect/[email protected]/reporter.go:23
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to