guoqqqi commented on a change in pull request #1998:
URL: https://github.com/apache/apisix-dashboard/pull/1998#discussion_r676795398
##########
File path: web/src/components/Plugin/UI/limit-count.tsx
##########
@@ -135,7 +145,7 @@ const RedisClusterForm: React.FC = () => {
</Form.Item>
</Col>
<Col style={{ ...removeBtnStyle, marginLeft: -10 }}>
- {fields.length > 1 ? (
+ {fields.length > minLength ? (
Review comment:
I think it would be better to change this part of the Conditional
(ternary) operator to the && operator
##########
File path: web/src/components/Plugin/UI/limit-count.tsx
##########
@@ -149,14 +159,14 @@ const RedisClusterForm: React.FC = () => {
</Form.Item>
<Form.Item {...FORM_ITEM_WITHOUT_LABEL}>
- <Button
+ {fields.length < maxLength?(<Button
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
