spacewander commented on a change in pull request #4676:
URL: https://github.com/apache/apisix/pull/4676#discussion_r677048124



##########
File path: t/core/ctx.t
##########
@@ -1008,3 +1008,23 @@ GET /hello
 hello world
 --- error_log eval
 qr/request log: 
\{"route_id":"1","route_name":"my_route","service_id":"1","service_name":"my_service"\}/
+
+
+
+=== TEST 36: support dash in the args

Review comment:
       Could you add the test in t/core/ctx2.t? Note that we already set up 
request & no_error_log there:
   
https://github.com/apache/apisix/blob/e3e018315311e0ca201f17579f9106eb88a834d1/t/core/ctx2.t#L23-L37




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to