spacewander commented on a change in pull request #4676:
URL: https://github.com/apache/apisix/pull/4676#discussion_r679629577
##########
File path: apisix/core/ctx.lua
##########
@@ -164,16 +163,15 @@ do
end
end
- elseif core_str.has_prefix(key, "arg_") then
- local args = t.args
- local arg_key = sub_str(key, 5)
- local m, err = ngx_re_match(args, "(^|&)" .. arg_key ..
"=([^&]*)(&|$)", "jo")
- if err then
- log.warn("failed to fetch arg value by key: ",
- key, " error: ", err)
- end
- if m then
- val = m[2]
+ elseif core_str.has_prefix(key, "uri_args_") then
+ local arg_key = sub_str(key, 10)
+ local args = ngx.req.get_uri_args()[arg_key]
Review comment:
Let's use `core.request.get_uri_args`
##########
File path: apisix/core/ctx.lua
##########
@@ -164,16 +163,15 @@ do
end
end
- elseif core_str.has_prefix(key, "arg_") then
- local args = t.args
- local arg_key = sub_str(key, 5)
- local m, err = ngx_re_match(args, "(^|&)" .. arg_key ..
"=([^&]*)(&|$)", "jo")
- if err then
- log.warn("failed to fetch arg value by key: ",
- key, " error: ", err)
- end
- if m then
- val = m[2]
+ elseif core_str.has_prefix(key, "uri_args_") then
Review comment:
Err... Let's use the old name "arg_".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
